Skip to content

Add CI for Xtrabackup #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

samuel40791765
Copy link
Contributor

Issues:

Addresses CryptoAlg-2926

Description of changes:

We've added support for Xtrabackup in #2273, this ensures that the build doesn't break.

Call-outs:

N/A

Testing:

CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (3d3d3a3) to head (d9c2133).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2275   +/-   ##
=======================================
  Coverage   78.73%   78.74%           
=======================================
  Files         616      616           
  Lines      107584   107588    +4     
  Branches    15286    15284    -2     
=======================================
+ Hits        84709    84716    +7     
+ Misses      22221    22218    -3     
  Partials      654      654           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuel40791765 samuel40791765 force-pushed the xtra-backup branch 3 times, most recently from 9d03114 to cff5e57 Compare April 1, 2025 21:09
@samuel40791765 samuel40791765 marked this pull request as ready for review April 1, 2025 21:19
@samuel40791765 samuel40791765 requested a review from a team as a code owner April 1, 2025 21:19
Copy link
Contributor

@smittals2 smittals2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuel40791765
Copy link
Contributor Author

looks like build failed for xtrabackup

Yeah the build's pretty large so looks like we'll need a beefier instance. Thanks for the call out!

@samuel40791765 samuel40791765 merged commit 7496445 into aws:main Apr 3, 2025
111 of 113 checks passed
@samuel40791765 samuel40791765 deleted the xtra-backup branch April 3, 2025 18:20
@justsmth justsmth mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants